Truly Dynamic Event #4274
Merged
Truly Dynamic Event #4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsharm
reviewed
Jun 18, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
mrsharm
reviewed
Jun 18, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
mrsharm
reviewed
Jun 18, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
mrsharm
reviewed
Jun 18, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
mrsharm
reviewed
Jun 18, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
mrsharm
reviewed
Jun 18, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/GC.Analysis.API.csproj
Show resolved
Hide resolved
mrsharm
reviewed
Jun 18, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/GC.Analysis.API.csproj
Show resolved
Hide resolved
mrsharm
reviewed
Jun 18, 2024
src/benchmarks/gc/GC.Infrastructure/Notebooks/Examples/GCAnalysisExamples.ipynb
Show resolved
Hide resolved
mrsharm
reviewed
Jun 18, 2024
mrsharm
reviewed
Jun 18, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
mrsharm
reviewed
Jun 18, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
mrsharm
reviewed
Jun 18, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/GC.Infrastructure.Core.csproj
Show resolved
Hide resolved
cshung
force-pushed
the
public/truly-dynamic-event
branch
from
6cd369d
to
ec7ff57
Compare
3 tasks
cshung
force-pushed
the
public/truly-dynamic-event
branch
2 times, most recently
from
c07614a
to
4c3e7d6
Compare
cshung
force-pushed
the
public/truly-dynamic-event
branch
3 times, most recently
from
bcd4c83
to
ef37cb3
Compare
cshung
force-pushed
the
public/truly-dynamic-event
branch
5 times, most recently
from
5e08c1b
to
0b722d2
Compare
mrsharm
reviewed
Jul 2, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Show resolved
Hide resolved
mrsharm
reviewed
Jul 2, 2024
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
Outdated
Show resolved
Hide resolved
mrsharm
previously approved these changes
Jul 2, 2024
cshung
force-pushed
the
public/truly-dynamic-event
branch
from
0b722d2
to
e06b946
Compare
cshung
force-pushed
the
public/truly-dynamic-event
branch
from
e06b946
to
e46e782
Compare
|
@cincuranet - could we please get this PR merged, seems like the Build Analysis failures are unrelated: ❌The pipeline is not valid. Job windows_22H2_x64_scenarios__Open: Step AzureCLI input connectedServiceNameARM references service connection .NET Performance (790c4451-dad9-4fda-af8b-10bd9ca328fa) which could not be found. The service connection does not exist, has been disabled or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz. Job ubuntu_2204_x64_scenarios__Open: Step AzureCLI input connectedServiceNameARM references service connection .NET Performance (790c4451-dad9-4fda-af8b-10bd9ca328fa) which could not be found. The service connection does not exist, has been disabled or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz. Thanks! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Open
3 tasks
|
Error was fixed earlier this week and this PR is approved by correct people, merging 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently in a prototype state. (It is easier to review by commits)
This change:
And some other cleanups
The dynamic event consumption part can only work with microsoft/perfview#2051.